We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If an abort signal is passed, it is first included in the request options:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L99-L101
Then later, the abort signal will be added to the race promises:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L144-L154
It seems like the latter block of code can be removed. Relying solely on fetch's internal abort signal signally mechanism seems preferable.
fetch
The text was updated successfully, but these errors were encountered:
The latter code block also suffers from the same issue that I reported here: aws/aws-sdk-js-v3#4872.
Sorry, something went wrong.
requestTimeout is also faulty, as it does not cancel in-flight requests:
requestTimeout
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/request-timeout.ts#L1-L11
can track release in aws/aws-sdk-js-v3#4872
Successfully merging a pull request may close this issue.
If an abort signal is passed, it is first included in the request options:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L99-L101
Then later, the abort signal will be added to the race promises:
https://github.com/awslabs/smithy-typescript/blob/2f70f105a1093c0c5d1caaa84ce292e5917f31ec/packages/fetch-http-handler/src/fetch-http-handler.ts#L144-L154
It seems like the latter block of code can be removed. Relying solely on
fetch
's internal abort signal signally mechanism seems preferable.The text was updated successfully, but these errors were encountered: