Fix tracing-subscriber missing regex features issue
#2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround until tokio-rs/tracing#2566 fixes this.
crisidev
reviewed
Apr 21, 2023
jjant
changed the title
regex-tracing-subscriber missing feature issueregex-tracing-subscriber missing features issue
jjant
changed the title
regex-tracing-subscriber missing features issuetracing-subscriber missing regex features issue
crisidev
approved these changes
Apr 21, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
alexjg
added a commit
to automerge/automerge
that referenced
this pull request
Apr 22, 2023
Due to a series of unfortunate events involving feature resoution and the tracing-subscriber and regex crates, the tracing-subscriber integration in our tests was crashing. This is detailed here: smithy-lang/smithy-rs#2618 For now we work around this by adding a dev dependency on regex which enables the required features. tracing-subscriber will be updated shortly and then we will need to get the updated tracing-subscriber into test-log and then we can relax.
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Description See #2619. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
## Description See #2619. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2619.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.