Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for tracing-subscriber missing regex features. #2619

Closed
jjant opened this issue Apr 21, 2023 · 1 comment
Closed

Remove workaround for tracing-subscriber missing regex features. #2619

jjant opened this issue Apr 21, 2023 · 1 comment

Comments

@jjant
Copy link
Contributor

jjant commented Apr 21, 2023

Added a workaround for tokio-rs/tracing#2565 in #2618. We should remove that workaround when the mentioned issue is fixed.

These missing features caused tests to fail like this: https://github.com/awslabs/smithy-rs/actions/runs/4763005344/jobs/8465943814.
@jjant jjant mentioned this issue Apr 21, 2023
Merged
jjant added a commit that referenced this issue Apr 21, 2023
@jjant
Link to #2619
847af3d
crisidev pushed a commit that referenced this issue Apr 21, 2023
@jjant
Fix tracing-subscriber missing regex features issue (#2618)
dd517bc 
## Description
See #2619. 

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
unexge pushed a commit that referenced this issue Apr 24, 2023
@jjant @unexge
Fix tracing-subscriber missing regex features issue (#2618)
a593757 
## Description
See #2619. 

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
rcoh pushed a commit that referenced this issue Apr 24, 2023
@jjant @rcoh
Fix tracing-subscriber missing regex features issue (#2618)
1b138b0 
## Description
See #2619. 

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@jdisanti
Copy link
Collaborator

jdisanti commented Apr 5, 2024

Looks like this was done a while ago.

@jdisanti jdisanti closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @jjant