Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMFIT-984: Adding Xcode Warnings to PR #119

Merged
merged 17 commits into from
Apr 7, 2020
Merged

SMFIT-984: Adding Xcode Warnings to PR #119

Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5896f5b
added danger xode warnings
Mar 31, 2020
d2deca0
chnaged path
Mar 31, 2020
ef3aa4f
fixed path
Mar 31, 2020
e63a7ce
testing inline mode
Mar 31, 2020
f1ed03d
debugging
Apr 1, 2020
788f9c0
debugging
Apr 1, 2020
b86c0e8
debugging
Apr 1, 2020
e5229f7
debugging
Apr 1, 2020
f9b6889
debugging
Apr 1, 2020
b55781e
debugging
Apr 1, 2020
bb7d710
debugging
Apr 1, 2020
8f83a1c
debugging
Apr 1, 2020
6575b48
debugging
Apr 1, 2020
6ef30af
debugging
Apr 1, 2020
5cbf2b7
debugging
Apr 1, 2020
688e413
removed debug prints
Apr 1, 2020
74ffaf5
Checking if errors.json exists, before running xocde_summary.report
Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions commons/smf_danger/Dangerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,18 @@ else

message(ticket_message)
end

## XCODE WARNINGS
xcode_summary.inline_mode = true
xcode_summary.ignored_files = 'Pods/**'

xcode_summary.ignored_results { |result|

if result.location.nil?
result.message.scan(/.*\.swift.*/).empty?
else
File.fnmatch('*[^.swift]', result.location.file_path)
end
}

xcode_summary.report 'build/reports/errors.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this ignore a missing file in case of android?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. @UrsKahmann might want to check that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added check so its only executed if the file exists