SMFIT-984: Adding Xcode Warnings to PR #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 31, 2020 12:27
TimDepping
previously approved these changes
Apr 2, 2020
kmeinh
previously approved these changes
Apr 3, 2020
Tomusm
previously approved these changes
Apr 3, 2020
timfreiheit
reviewed
Apr 3, 2020
commons/smf_danger/Dangerfile
Outdated
| end | ||
| } | ||
|
|
||
| xcode_summary.report 'build/reports/errors.json' |
There was a problem hiding this comment.
does this ignore a missing file in case of android?
There was a problem hiding this comment.
good question. @UrsKahmann might want to check that
There was a problem hiding this comment.
Added check so its only executed if the file exists
timfreiheit
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new plugin danger-xcode-summary to add xcode warnings to the PRs. This will only show warnings for .swift files. The warnings should also be inline after this is merged.