test: fixed race condition with endpoint deletion #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aureamunoz
approved these changes
Oct 24, 2023
|
fixing format |
client.endpoints().inNamespace(defaultNamespace).withName(serviceName).delete() doesn't wait for the operation to complete in the cluster. We either need to wait for a condition where these endpoint is null. Or use the convenience .withTimeout DSL method so that Kubernetes client blocks the thread for us in a best effort attempt to wait until the referenced Kubernetes object no longer exists.
manusa
force-pushed
the
test/fetch-instances
branch
from
5e59ce3 to
483789f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #667
Relates to #689
doesn't wait for the operation to complete in the cluster. It limits to send the HTTP request to the Kube API and return.
We either need to wait for a condition where this endpoint is null.
Or use the convenience
.withTimeoutDSL method so that Kubernetes client blocks the thread for us in a best effort attempt to wait until the referenced Kubernetes object no longer exists.