Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Kubernetes tests beacuse no reason to disable them #689

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

aureamunoz
Copy link
Collaborator

@aureamunoz aureamunoz commented Oct 19, 2023

Fix #667

@aureamunoz aureamunoz marked this pull request as draft October 19, 2023 13:46
@aureamunoz aureamunoz marked this pull request as ready for review October 23, 2023 14:58
@aureamunoz
Copy link
Collaborator Author

I've tried to reproduce the problem but the error seems be gone. I shared the problem with @manusa (Marc Nuri) and we didn't find a consistent reason to keep the tests disabled so I propose to re-enable them and see what happen in the future.

@aureamunoz aureamunoz requested a review from cescoffier October 23, 2023 15:01
@cescoffier
Copy link
Contributor

Can you rename the PR and squash the commit and let's see how it goes.

@aureamunoz aureamunoz changed the title try to reproduce errors Enable Kubernetes tests beacuse no reason to disable them Oct 23, 2023
@aureamunoz aureamunoz merged commit ff85aab into smallrye:main Oct 23, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Kubernetes Service Discovery flaky tests
2 participants