fix: video having no duration (with recordrtc dependency from GitHub) #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording the presentation, the resulting video is corrupted as the duration is not/incorrectly detected by video players.
This issue explains the problem and gives a solution: we have to wrap the blob in
getSeekableBlob
function.An important thing to note is that
getSeekableBlob
function requiresEBML
as dependency.I have developed several PR solving the problem and using different ways to import
EBML
as each of them have pros and cons.This PR imports
recordrtc
dependency twice (second time from GitHub URL instead of from npm registry) in order to have the requiredEBML.js
file (which is not packed in the npm registry version ofrecordrtc
)Cons: we declare the same dependency twice and we use GitHub dependency (not a good practice?).
See other PRs: