fix: video having no duration (with CDN) #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.B.: we're importing a JS file from a CDN in index.html, which seems not good (we depend on internet connection and CDN availability)
marob
changed the title
This was referenced Feb 18, 2022
|
Thanks but I'd prefer to have this fixed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording the presentation, the resulting video is corrupted as the duration is not/incorrectly detected by video players.
This issue explains the problem and gives a solution: we have to wrap the blob in
getSeekableBlobfunction.An important thing to note is that
getSeekableBlobfunction requiresEBMLas dependency.I have developed several PR solving the problem and using different ways to import
EBMLas each of them have pros and cons.This PR imports a JS file from a CDN in
index.html.Cons: we depend on internet connection and CDN availability.
See other PRs: