Major update #80
Merged
Major update #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the duplicate code and wrap it in a function so it can be customised for the page it's being used on.
Includes new graphics/flags and requires many more, this is a branch so these new improvements can be studied and improved on and discussed. Conflicts: README.md css/silk.css favicon.ico global.js images/favicon.ico
Rather than duplicating utility functions for each section move them to one location and share it between them.
HTML export now lets the user select which fields they want to export.
un1versal
pushed a commit
that referenced
this pull request
Jul 4, 2014
- Major clean up of the TV section - Major clean up of the Movie section - Restore view movies by genre - Upgrade to ExtJS v3.4.1.1 - Use light gray theme (dark gray theme was removed form ExtJS) - Add media flags from the Confluence theme (Issue #26) - Start sharing common code (XWMM.util) - Rewrite the HTML export feature (Issue #62)
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke GH, well just #77. So I've created a new PR. This is a collection of multiple updates:
I've merged the separate branches into one to save a repeat of the other days merge, rebase repeat. 😄
With this lot complete I would say we're in a good position for a 4.1 release to get people testing it. Everything is now working (touch wood) in the movies and TV section with the exception of the Manage Genre window.
As far as features go the To Do list is down to: