Major clean up of the Movies and TV sections #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the duplicate code and wrap it in a function so it can be customised for the page it's being used on.
ghost
mentioned this pull request
|
Once this has been merged it would make a good point for an RC release. |
ghost
mentioned this pull request
ghost
changed the title
ghost
mentioned this pull request
|
I've rolled the 3 open PR's into one. |
Includes new graphics/flags and requires many more, this is a branch so these new improvements can be studied and improved on and discussed. Conflicts: README.md css/silk.css favicon.ico global.js images/favicon.ico
Rather than duplicating utility functions for each section move them to one location and share it between them.
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, it's a major clean up of the Movies and TV sections. This also restores the movies by genre view.