Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce int and float types to trace.proto #782

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

vthacker
Copy link
Contributor

@vthacker vthacker commented Feb 28, 2024

Summary

Part 1 - Introduce int and float types to trace.proto

Kaldb Schema PR breakdown - 5 part series to introduce schema configs to Kaldb

  1. introduce a concept of int and float to trace.proto
  2. remove the concept of index transformer - it's always trace.span
  3. use trace.span to create lucene documents instead of LogMessage
  4. insert schema info to trace.proto in the preprocssor
  5. leverage schema in the indexer

@vthacker vthacker merged commit 593bc6d into master Feb 29, 2024
3 checks passed
@vthacker vthacker deleted the vthacker_schema_pt1 branch February 29, 2024 17:29
@bryanlb bryanlb added this to the Custom schema support milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants