WIP: Remove LogMessage and use Trace.Span as the carrier object for documents #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
force-pushed
the
vthacker_log_message
branch
4 times, most recently
from
9fe3a56 to
191461f
Compare
vthacker
changed the title
vthacker
force-pushed
the
vthacker_log_message
branch
2 times, most recently
from
18ededc to
efe4cff
Compare
vthacker
force-pushed
the
vthacker_log_message
branch
from
efe4cff to
edd0636
Compare
mansu
reviewed
Mar 1, 2024
kaldb/src/main/java/com/slack/kaldb/logstore/schema/SchemaAwareLogDocumentBuilderImpl.java
Show resolved
Hide resolved
vthacker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to standardize the
Trace.Spanformat the indexer knows how to parse into lucene documents. We remove theLogMessageclass and various parsers that were Slack specific.The main motivation for this PR is the preprocessor which will create
Trace.Spanobjects in #778 will add schema information. And the indexer should work off theTrace.Spaobject to create Lucene documents so that the schema could be leveraged.We will need at least 1 additional PR to get to to the end state, but breaking it down to make things easier to reason with and also deploy