Change HPA to account for Kubernetes tolerances #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlb
force-pushed
the
bburkholder/hpa-adjustments
branch
3 times, most recently
from
837b479 to
171c161
Compare
bryanlb
changed the title
|
Should be merged after #680 |
bryanlb
force-pushed
the
bburkholder/hpa-adjustments
branch
from
171c161 to
685d5c4
Compare
vthacker
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the HPA logic to account for the Kubernetes tolerances (see https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#algorithm-details).
This also changes the implicit maintenance window to instead return a nominal value, as the implicit maintenance mode effectively locks out autoscaling until the next deploy for that replicaset.