Add AWS S3 Transfer Manager #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlb
force-pushed
the
bburkholder/transfer-manager
branch
from
383a3fa to
19fcb40
Compare
Adds transfer manager for upload/download methods, adds tests, fixes an edge case with getS3ObjectMetadata
bryanlb
force-pushed
the
bburkholder/transfer-manager
branch
from
19fcb40 to
ce28819
Compare
bryanlb
commented
Sep 20, 2023
kaldb/src/test/java/com/slack/kaldb/elasticsearchApi/OpenSearchBulkEndpointTest.java
Show resolved
Hide resolved
bryanlb
force-pushed
the
bburkholder/transfer-manager
branch
3 times, most recently
from
3f7515e to
80a0db6
Compare
bryanlb
force-pushed
the
bburkholder/transfer-manager
branch
from
80a0db6 to
1a5f03c
Compare
vthacker
reviewed
Sep 21, 2023
vthacker
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the S3 Transfer manager for uploading and downloading files and folders. If a folder is detected on upload or download this will automatically switch to using the directory APIs which have much better concurrency and throughput.
This also adds a missing test suite from when we split off the CRT client, and fixes a previously unknown exception issue. As mentioned in the new CRT docblock, we need to revisit our entire blobfs abstraction as the current design isn't working well with the direction of the APIs we need to support.