Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emit on user change to Slack client #1

Closed
lambtron opened this issue Nov 18, 2014 · 1 comment
Closed

Add emit on user change to Slack client #1

lambtron opened this issue Nov 18, 2014 · 1 comment

Comments

@lambtron
Copy link

Hi @paulhammond and @grantmd,

Good news! We've been able to successfully migrate our bot, Hermes, from Hipchat to Slack without much difficulty!

One thing we'd like to add to your Slack client is to add an emitter to fire on new user or user change. This way, when Hermes is running, a new user who joins the organization would be able to interact with Hermes (Hermes would dynamically add the new user to the list of all users).

We were thinking of just adding a single line as below:
screen shot 2014-11-17 at 5 25 18 pm
Here:
https://github.com/slackhq/node-slack-client/blob/master/src/client.coffee#L386

Thoughts?

/cc @stevenmiller888

@grantmd
Copy link
Contributor

grantmd commented Nov 18, 2014

Yep, great idea. Added here: 4bf44ee

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants