-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emit on user change to Slack client #1
Comments
Yep, great idea. Added here: 4bf44ee Thanks! |
hwz
added a commit
that referenced
this issue
Sep 28, 2017
Roach
pushed a commit
that referenced
this issue
Sep 28, 2017
This was referenced Dec 11, 2018
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this issue
Mar 20, 2019
add a url verification error handling test
16 tasks
2 tasks
hello-ashleyintech
added a commit
that referenced
this issue
Nov 8, 2022
hello-ashleyintech
added a commit
that referenced
this issue
Nov 8, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @paulhammond and @grantmd,
Good news! We've been able to successfully migrate our bot, Hermes, from Hipchat to Slack without much difficulty!
One thing we'd like to add to your Slack client is to add an emitter to fire on new user or user change. This way, when Hermes is running, a new user who joins the organization would be able to interact with Hermes (Hermes would dynamically add the new user to the list of all users).
We were thinking of just adding a single line as below:
Here:
https://github.com/slackhq/node-slack-client/blob/master/src/client.coffee#L386
Thoughts?
/cc @stevenmiller888
The text was updated successfully, but these errors were encountered: