-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maintainer's guide to add more specific instructions for releases #1511
Merged
hello-ashleyintech
merged 4 commits into
slackapi:main
from
hello-ashleyintech:update-maintainers-guide
Jul 12, 2022
Merged
Update maintainer's guide to add more specific instructions for releases #1511
hello-ashleyintech
merged 4 commits into
slackapi:main
from
hello-ashleyintech:update-maintainers-guide
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-ashleyintech
added
docs
M-T: Documentation work only
discussion
M-T: An issue where more input is needed to reach a decision
labels
Jul 8, 2022
filmaj
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a bunch of suggestions, thanks a ton for improving these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
discussion
M-T: An issue where more input is needed to reach a decision
docs
M-T: Documentation work only
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When going over releasing a new version of a package within
node-slack-sdk
, we identified some areas where the Maintainer's Guide could be updated to capture more specifics in the Releases section.Specifically, steps 1, 2, 5, 6, 8, 9, and 10 have some added information regarding addressing GitHub Milestones, creating a new branch off of
main
for the release PR, and where to post release information.Some additional topics came up regarding improving this guide that require more discussion -- see PR comments below for more information and to join the discussion.
Requirements (place an
x
in each[ ]
)