Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer's guide to add more specific instructions for releases #1511

Merged

Conversation

hello-ashleyintech
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech commented Jul 8, 2022

Summary

When going over releasing a new version of a package within node-slack-sdk, we identified some areas where the Maintainer's Guide could be updated to capture more specifics in the Releases section.

Specifically, steps 1, 2, 5, 6, 8, 9, and 10 have some added information regarding addressing GitHub Milestones, creating a new branch off of main for the release PR, and where to post release information.

Some additional topics came up regarding improving this guide that require more discussion -- see PR comments below for more information and to join the discussion.

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added docs M-T: Documentation work only discussion M-T: An issue where more input is needed to reach a decision labels Jul 8, 2022
@hello-ashleyintech hello-ashleyintech self-assigned this Jul 8, 2022
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a bunch of suggestions, thanks a ton for improving these!

.github/maintainers_guide.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Show resolved Hide resolved
.github/maintainers_guide.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Outdated Show resolved Hide resolved
.github/maintainers_guide.md Outdated Show resolved Hide resolved
@hello-ashleyintech hello-ashleyintech merged commit ce8558e into slackapi:main Jul 12, 2022
@hello-ashleyintech hello-ashleyintech deleted the update-maintainers-guide branch July 12, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion M-T: An issue where more input is needed to reach a decision docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants