Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.conversations.whitelist.* API #487

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 11, 2020

Summary

This pull request adds new Web API support:

Refer to https://api.slack.com/enterprise/workspaces#whitelists for details.

Requirements (place an x in each [ ])

https://api.slack.com/enterprise/workspaces#whitelists

* admin.conversations.whitelist.add
* admin.conversations.whitelist.remove
* admin.conversations.whitelist.listGroupsLinkedToChannel
@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Jun 11, 2020
@seratch seratch added this to the 1.0.9 milestone Jun 11, 2020
@seratch seratch requested a review from stevengill June 11, 2020 05:10
@seratch seratch self-assigned this Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #487 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #487      +/-   ##
============================================
+ Coverage     83.80%   83.87%   +0.06%     
- Complexity     2413     2428      +15     
============================================
  Files           251      251              
  Lines          6482     6510      +28     
  Branches        585      585              
============================================
+ Hits           5432     5460      +28     
  Misses          687      687              
  Partials        363      363              
Impacted Files Coverage Δ Complexity Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 98.34% <ø> (ø) 8.00 <0.00> (ø)
...java/com/slack/api/methods/RequestFormBuilder.java 93.35% <100.00%> (+0.08%) 236.00 <3.00> (+3.00)
...slack/api/methods/impl/AsyncMethodsClientImpl.java 98.40% <100.00%> (+0.03%) 300.00 <6.00> (+6.00)
.../com/slack/api/methods/impl/MethodsClientImpl.java 92.42% <100.00%> (+0.11%) 423.00 <6.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd91d6...414f4bc. Read the comment docs.

@seratch seratch merged commit e50f8d6 into slackapi:master Jun 11, 2020
@seratch seratch deleted the admin-conversations-whitelist branch June 11, 2020 22:09
seratch added a commit that referenced this pull request Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
seratch added a commit that referenced this pull request Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants