Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UsersLookupByEmailResponse to the right package (source code compatible) #486

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 11, 2020

Summary

While working on #484, I've noticed that UsersLookupByEmailResponse is mistakenly replaced under channels package 🤦

This pull request corrects this issue without bringing any breaking changes to existing apps. We'll be removing the deprecated class under channels package since v1.1 release.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Jun 11, 2020
@seratch seratch added this to the 1.0.x milestone Jun 11, 2020
@seratch seratch requested a review from stevengill June 11, 2020 04:11
@seratch seratch self-assigned this Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #486 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #486   +/-   ##
=========================================
  Coverage     83.80%   83.80%           
- Complexity     2413     2414    +1     
=========================================
  Files           251      252    +1     
  Lines          6482     6483    +1     
  Branches        585      585           
=========================================
+ Hits           5432     5433    +1     
  Misses          687      687           
  Partials        363      363           
Impacted Files Coverage Δ Complexity Δ
...slack/api/methods/impl/AsyncMethodsClientImpl.java 98.37% <ø> (ø) 294.00 <0.00> (ø)
.../com/slack/api/methods/impl/MethodsClientImpl.java 92.30% <ø> (ø) 417.00 <0.00> (ø)
...ods/response/users/UsersLookupByEmailResponse.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd91d6...1e64a67. Read the comment docs.

@seratch seratch modified the milestones: 1.0.x, 1.0.9 Jun 11, 2020
@seratch seratch merged commit c8ef48a into slackapi:master Jun 11, 2020
@seratch seratch deleted the move-UsersLookupByEmailResponse branch June 11, 2020 22:16
seratch added a commit that referenced this pull request Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
seratch added a commit that referenced this pull request Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch
* [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch
* [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch
* [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant