-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UsersLookupByEmailResponse to the right package (source code compatible) #486
Merged
seratch
merged 1 commit into
slackapi:master
from
seratch:move-UsersLookupByEmailResponse
Jun 11, 2020
Merged
Move UsersLookupByEmailResponse to the right package (source code compatible) #486
seratch
merged 1 commit into
slackapi:master
from
seratch:move-UsersLookupByEmailResponse
Jun 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
project:slack-api-client
project:slack-api-client
labels
Jun 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage 83.80% 83.80%
- Complexity 2413 2414 +1
=========================================
Files 251 252 +1
Lines 6482 6483 +1
Branches 585 585
=========================================
+ Hits 5432 5433 +1
Misses 687 687
Partials 363 363
Continue to review full report at Codecov.
|
seratch
added a commit
that referenced
this pull request
Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
seratch
added a commit
that referenced
this pull request
Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented
project:slack-api-client
project:slack-api-client
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #484, I've noticed that
UsersLookupByEmailResponse
is mistakenly replaced underchannels
package 🤦This pull request corrects this issue without bringing any breaking changes to existing apps. We'll be removing the deprecated class under
channels
package since v1.1 release.Requirements (place an
x
in each[ ]
)