-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GSON and other optional dependencies #1077
Conversation
@@ -68,6 +68,7 @@ | |||
<aws.s3.version>[1.12.62,1.13.0)</aws.s3.version> | |||
<junit.version>4.13.2</junit.version> | |||
<logback.version>1.2.11</logback.version> | |||
<logback-slf4j-v2.version>1.4.4</logback-slf4j-v2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This slf4j-api v2 compatible version is supposed to be used only for test code and example projects. See also: #1034
Ah, UnknownPropertyDetectionAdapterFactory's internal field access fails with the new version. I will look into this tomorrow in my timezone. |
|
c7dec9f
to
1168b93
Compare
Codecov Report
@@ Coverage Diff @@
## main #1077 +/- ##
=========================================
Coverage 75.99% 76.00%
- Complexity 3775 3776 +1
=========================================
Files 413 413
Lines 11741 11750 +9
Branches 1150 1152 +2
=========================================
+ Hits 8922 8930 +8
Misses 2126 2126
- Partials 693 694 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request upgrades dependencies before the upcoming minor version release. The only critical one is GSON's minor upgrade but I believe that it's safe enough.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.