Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade slf4j-api to 2.0 #1034

Open
6 tasks done
seratch opened this issue Aug 22, 2022 · 3 comments
Open
6 tasks done

Upgrade slf4j-api to 2.0 #1034

seratch opened this issue Aug 22, 2022 · 3 comments
Assignees
Milestone

Comments

@seratch
Copy link
Member

seratch commented Aug 22, 2022

slf4j project released a new major version - 2.0.

According to the migration guide, it's safe to upgrade the dependency in this project but it requires a minor version bump of this SDK. EDIT: I might be wrong. Perhaps, if we release a new version with slf4j-api 2.0 dependency, real-world apps such as Spring Boot web apps would be suffered from behavior changes. We should hold off upgrading to 2.0 for the time being.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. 🙇

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added this to the 1.24.1 milestone Aug 22, 2022
@seratch seratch self-assigned this Aug 22, 2022
@seratch
Copy link
Member Author

seratch commented Aug 23, 2022

Still waiting for logback-classic 1.3.0 release: https://github.com/qos-ch/logback/tags

@seratch seratch modified the milestones: 1.25.0, 2.0.0 Aug 23, 2022
@seratch
Copy link
Member Author

seratch commented Aug 23, 2022

EDIT: I might be wrong. Perhaps, if we release a new version with slf4j-api 2.0 dependency, real-world apps such as Spring Boot web apps would be suffered from behavior changes. We should hold off upgrading to 2.0 for the time being.

@seratch
Copy link
Member Author

seratch commented Nov 8, 2022

Another factor we should consider for this upgrade is that logback-classic 1.4 and perhaps other implementations of sfl4j-api v2 no longer supports Java 1.8. Yes, the version is long-lived old version but this SDK still supports the version for broader audience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant