Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure transfers with additional permissions #435

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Fix Azure transfers with additional permissions #435

merged 2 commits into from
Jul 11, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Jun 28, 2022

  • Bump poetry.lock
  • Seems to fix Azure transfers

@linear
Copy link

linear bot commented Jun 28, 2022

SKY-183 Azure transfers are broken on main

See: #408

@parasj parasj force-pushed the paras/sky-183-azure-transfers-are-broken-on-main branch 2 times, most recently from 0764e14 to da64fa1 Compare July 11, 2022 20:38
@parasj
Squashed commit of the following:
f7ade95 
commit da64fa1
Author: Paras Jain <[email protected]>
Date:   Mon Jul 11 20:38:38 2022 +0000

    Squashed commit of the following:

    commit 0764e14
    Author: Paras Jain <[email protected]>
    Date:   Mon Jul 11 20:34:58 2022 +0000

        Squashed commit of the following:

        commit cd30b15
        Merge: 200c2f4 91724d7
        Author: Paras Jain <[email protected]>
        Date:   Mon Jul 11 20:34:30 2022 +0000

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 200c2f4
        Author: Paras Jain <[email protected]>
        Date:   Mon Jul 11 13:30:56 2022 -0700

            Remove create_bucket option from ObjStoreInterface (#443)

        commit c260d7a
        Merge: 3181f2f 0e29e02
        Author: Paras Jain <[email protected]>
        Date:   Mon Jul 11 18:56:24 2022 +0000

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 3181f2f
        Merge: 15f380a f08b9d9
        Author: Paras Jain <[email protected]>
        Date:   Thu Jul 7 20:18:54 2022 +0000

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 15f380a
        Merge: ed5a8be e5c97e0
        Author: Paras Jain <[email protected]>
        Date:   Wed Jun 29 18:14:02 2022 -0700

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit ed5a8be
        Merge: 80bfcc6 7402a15
        Author: Paras Jain <[email protected]>
        Date:   Wed Jun 29 12:53:19 2022 -0700

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 80bfcc6
        Merge: 00493b5 1598038
        Author: Paras Jain <[email protected]>
        Date:   Wed Jun 29 12:45:19 2022 -0700

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 00493b5
        Author: Paras Jain <[email protected]>
        Date:   Tue Jun 28 01:33:37 2022 +0000

            Print error message

        commit a4a6a5e
        Author: Paras Jain <[email protected]>
        Date:   Tue Jun 28 01:27:29 2022 +0000

            Format

        commit d0669c7
        Author: Paras Jain <[email protected]>
        Date:   Tue Jun 28 01:27:22 2022 +0000

            Seems to work!

        commit c3124b8
        Author: Paras Jain <[email protected]>
        Date:   Tue Jun 28 00:19:47 2022 +0000

            Missing ref

        commit e362958
        Author: Paras Jain <[email protected]>
        Date:   Tue Jun 28 00:17:07 2022 +0000

            Seems to fix Azure transfers

        commit 9c5345d
        Author: Paras Jain <[email protected]>
        Date:   Mon Jun 27 22:06:56 2022 +0000

            Bump poetry.lock

        commit 48611f5
        Merge: 4d6632f a4c6d58
        Author: Paras Jain <[email protected]>
        Date:   Mon Jun 27 19:53:32 2022 +0000

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 4d6632f
        Merge: 50f618c 5afe0d8
        Author: Paras Jain <[email protected]>
        Date:   Mon Jun 27 16:21:13 2022 +0000

            Merge branch 'main' into paras/sky-183-azure-transfers-are-broken-on-main

        commit 50f618c
        Author: Paras Jain <[email protected]>
        Date:   Mon Jun 27 16:20:45 2022 +0000

            Verify transfer if no error occurred

        commit 8929b2f
        Author: Paras Jain <[email protected]>
        Date:   Mon Jun 27 16:20:31 2022 +0000

            Gate GCP firewall additions behind check

commit 00b5264
Author: Paras Jain <[email protected]>
Date:   Mon Jul 11 20:37:30 2022 +0000

    Partial azure changes
@parasj parasj force-pushed the paras/sky-183-azure-transfers-are-broken-on-main branch from da64fa1 to f7ade95 Compare July 11, 2022 20:41
@parasj
Copy link
Contributor Author

parasj commented Jul 11, 2022

Note: it takes up to 120s for Azure roles to propagate

@parasj parasj merged commit d5dd450 into main Jul 11, 2022
@parasj parasj deleted the paras/sky-183-azure-transfers-are-broken-on-main branch July 11, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@parasj