Remove questionary dependency (#434)

pyproject.toml

@@ -28,7 +28,6 @@ google-cloud-compute = ">=1.0.0"
 google-cloud-storage = ">=1.30.0"
 pandas = ">=1.0.0"
 paramiko = ">=2.7.2"
-questionary = ">=1.5.2"
 rich = ">=9.0.0"
 sshtunnel = ">=0.3.0"
 typer = ">=0.4.0"

skyplane/cli/cli.py

@@ -5,7 +5,6 @@
 from shlex import split
 import traceback
 
-import questionary
 import typer
 
 import skyplane.cli.cli_aws
@@ -337,16 +336,20 @@ def ssh():
 
     instance_map = {f"{i.region_tag}, {i.public_ip()} ({i.instance_state()})": i for i in instances}
     choices = list(sorted(instance_map.keys()))
-    instance_name = questionary.select("Select an instance", choices=choices).ask()
-    if instance_name is not None and instance_name in instance_map:
-        instance = instance_map[instance_name]
-        cmd = instance.get_ssh_cmd()
-        logger.info(f"Running SSH command: {cmd}")
-        logger.info("It may ask for a private key password, try `skyplane`.")
-        proc = subprocess.Popen(split(cmd))
-        proc.wait()
-    else:
-        typer.secho(f"No instance selected", fg="red")
+
+    # ask for selection
+    typer.secho("Select an instance:", fg="yellow", bold=True)
+    for i, choice in enumerate(choices):
+        typer.secho(f"{i+1}) {choice}", fg="yellow")
+    choice = typer.prompt(f"Enter a number: ", validators=[typer.Range(1, len(choices))])
+    instance = instance_map[choices[choice - 1]]
+
+    # ssh
+    cmd = instance.get_ssh_cmd()
+    logger.info(f"Running SSH command: {cmd}")
+    logger.info("It may ask for a private key password, try `skyplane`.")
+    proc = subprocess.Popen(split(cmd))
+    proc.wait()
 
 
 @app.command()

skyplane/cli/experiments/cli_profile.py

@@ -7,7 +7,6 @@
 from typing import List, Optional, Tuple
 
 import pandas as pd
-import questionary
 import typer
 
 from rich.progress import Progress
@@ -253,7 +252,7 @@ def setup(server: Server):
     logger.debug(f"Log directory: {log_dir}")
     sys.stdout.flush()
     sys.stderr.flush()
-    if not questionary.confirm(f"Launch experiment {experiment_tag}?", default=False).ask():
+    if not typer.confirm(f"\nRun experiment? (tag: {experiment_tag})", default=True):
         logger.error("Exiting")
         sys.exit(1)
 
@@ -427,9 +426,9 @@ def setup(server: Server):
     logger.debug(f"Log directory: {log_dir}")
     sys.stdout.flush()
     sys.stderr.flush()
-    # if not questionary.confirm(f"Launch experiment {experiment_tag}?", default=False).ask():
-    #     logger.error("Exiting")
-    #     sys.exit(1)
+    if not typer.confirm(f"\nRun experiment? (tag: {experiment_tag})", default=True):
+        logger.error("Exiting")
+        sys.exit(1)
 
     # define ping command
     def client_fn(instance_pair):