Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skylark init updates w/ explicit configuration #231

Merged
merged 5 commits into from
Apr 2, 2022
Merged

skylark init updates w/ explicit configuration #231

merged 5 commits into from
Apr 2, 2022

Conversation

parasj
Copy link
Contributor

@parasj parasj commented Mar 28, 2022 •
edited
Loading

Fixes #214

@parasj
Copy link
Contributor Author

parasj commented Mar 28, 2022

@antonzabreyko I made a draft PR to leave comments via reviews

parasj
parasj commented Mar 28, 2022
View reviewed changes
Copy link
Contributor Author

@parasj parasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks great. In general, I think we should just error out if skylark has not been configured yet; it should make some things simpler (e.g. no default config) and clearer.

skylark/cli/cli.py Show resolved Hide resolved
@parasj
Copy link
Contributor Author

parasj commented Apr 1, 2022

LGTM. Add an error stating to run skylark init if the aws_config file doesn't exist.

@antonzabreyko antonzabreyko merged commit 08e5820 into main Apr 2, 2022
@antonzabreyko antonzabreyko deleted the dev/anton/config-changes branch April 2, 2022 22:59
@parasj parasj changed the title [Draft] skylark init updates w/ explicit configuration skylark init updates w/ explicit configuration Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Skylark 0.1 alpha critical
Development

Successfully merging this pull request may close these issues.

Explicit region configuration in skylark init
2 participants
@parasj @antonzabreyko