Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit region configuration in skylark init #214

Closed
parasj opened this issue Mar 18, 2022 · 0 comments · Fixed by #231
Closed

Explicit region configuration in skylark init #214

parasj opened this issue Mar 18, 2022 · 0 comments · Fixed by #231

Comments

@parasj
Copy link
Contributor

parasj commented Mar 18, 2022

Region management:

  • skylark init should show the list of enabled regions to the user and ask them to confirm. This will fix the issue where listing GCP instances queries regions where a user does not have either Compute Engine or GCS enabled.
  • It will write those regions to ~/.skylark/aws_regions, etc. The user can edit these lists if needed.
  • If a cloud command fails in a specific region, do not catch the exception; we should surface this to the user.

Explicitly disable clouds:

  • If the user disables a cloud provider, skylark init should set a flag in the config to denote that the cloud is disabled. The cloud-specific auth classes should read this file to determine if a cloud is enabled.
  • The cloud auth classes should have no "magic"; if a cloud is disabled, do not attempt to auto-load credentials (e.g. google.auth.default)
  • This is different from what Fix Issue #211 #213 is doing; we should return errors to the user without catching them. Remove the try-catch from skylark/compute/gcp/gcp_auth.py.
@antonzabreyko antonzabreyko self-assigned this Mar 18, 2022
@parasj parasj moved this to Todo (backlog) in Skylark Alpha release Mar 29, 2022
@parasj parasj moved this from Todo (backlog) to In Progress in Skylark Alpha release Mar 29, 2022
@parasj parasj added this to the Skylark 0.1 alpha critical milestone Mar 31, 2022
Repository owner moved this from In Progress to Done in Skylark Alpha release Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants