Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1234: use common declaration of management type id in CI tests #1237

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

kgiusti
Copy link
Contributor

@kgiusti kgiusti commented Sep 26, 2023

Big rename-only patch.

@kgiusti kgiusti linked an issue Sep 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1237 (eb7dea6) into main (04d8712) will decrease coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 98.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   78.35%   78.29%   -0.06%     
==========================================
  Files         244      244              
  Lines       63253    63262       +9     
  Branches     5856     5858       +2     
==========================================
- Hits        49563    49533      -30     
- Misses      11056    11083      +27     
- Partials     2634     2646      +12     
Flag Coverage Δ
pysystemtests 87.62% <98.05%> (+<0.01%) ⬆️
pyunittests 54.60% <63.63%> (+0.16%) ⬆️
systemtests 72.32% <ø> (-0.11%) ⬇️
unittests 26.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
calculator 30.12% <63.63%> (+0.02%) ⬆️
systemtests 78.90% <98.05%> (-0.07%) ⬇️

@ganeshmurthy ganeshmurthy merged commit 8c7463a into skupperproject:main Sep 27, 2023
@kgiusti kgiusti deleted the ISSUE-1234 branch October 2, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the common entity type definitions in system_test.py
2 participants