Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the common entity type definitions in system_test.py #1234

Closed
ganeshmurthy opened this issue Sep 26, 2023 · 0 comments · Fixed by #1237
Closed

Use the common entity type definitions in system_test.py #1234

ganeshmurthy opened this issue Sep 26, 2023 · 0 comments · Fixed by #1237
Assignees
Milestone

Comments

@ganeshmurthy
Copy link
Contributor

ganeshmurthy commented Sep 26, 2023

There are many instances in the test code that do not use the common entity types that are already defined in system_test.py.

It would be good to use these common entity types in all system tests so there is one place that holds a record of these entity types (long form).

For example - the following types are already in system_test.py

HTTP_LISTENER_TYPE = 'io.skupper.router.httpListener'
TCP_LISTENER_TYPE = 'io.skupper.router.tcpListener'
HTTP_CONNECTOR_TYPE = 'io.skupper.router.httpConnector'
TCP_CONNECTOR_TYPE = 'io.skupper.router.tcpConnector'
CONNECTION_TYPE = 'io.skupper.router.connection'

Use the above types and add new types to system_test.py wherever necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants