We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are many instances in the test code that do not use the common entity types that are already defined in system_test.py.
It would be good to use these common entity types in all system tests so there is one place that holds a record of these entity types (long form).
For example - the following types are already in system_test.py
HTTP_LISTENER_TYPE = 'io.skupper.router.httpListener' TCP_LISTENER_TYPE = 'io.skupper.router.tcpListener' HTTP_CONNECTOR_TYPE = 'io.skupper.router.httpConnector' TCP_CONNECTOR_TYPE = 'io.skupper.router.tcpConnector' CONNECTION_TYPE = 'io.skupper.router.connection'
Use the above types and add new types to system_test.py wherever necessary
The text was updated successfully, but these errors were encountered:
Fixes skupperproject#1234: use common declaration of management type …
eb7dea6
…id in CI tests
Fixes #1234: use common declaration of management type id in CI tests (…
8c7463a
…#1237)
Fixes #1234: Additional fix. Use system_test.py constants in system_t…
1fa4df7
…ests_management.py (#1287)
kgiusti
Successfully merging a pull request may close this issue.
There are many instances in the test code that do not use the common entity types that are already defined in system_test.py.
It would be good to use these common entity types in all system tests so there is one place that holds a record of these entity types (long form).
For example - the following types are already in system_test.py
Use the above types and add new types to system_test.py wherever necessary
The text was updated successfully, but these errors were encountered: