Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template updates in preparation for course updates #28

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

heiskr
Copy link
Contributor

@heiskr heiskr commented Feb 13, 2023

Updates course template in preparation for updates across courses.

@heiskr heiskr requested review from a team February 13, 2023 22:54
Copy link

@gracepark gracepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heiskr heiskr merged commit d178008 into main Feb 13, 2023
@heiskr heiskr deleted the template-updates branch February 13, 2023 23:25
@sinsukehlab
Copy link
Contributor

It looks great, but I wonder how the Start course button will work in the courses. It is TBD in this repository.

@sinsukehlab
Copy link
Contributor

I don't think a generated repository should have the same name as the template repository. The name should be left for the forked repository.

@sinsukehlab
Copy link
Contributor

It looks great, but I wonder how the Start course button will work in the courses. It is TBD in this repository.

Using absolute URI references, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants