-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
step0 Scope - Keep the welcome paragraph visible after course start? #20
Conversation
instead of commenting it out
Details of this course
I would leave the Something like this
The skills/action-update-step would also have to be updated to accommodate for blocks being removed from comments instead of added. (i.e. unhide the details tags). Personally, I think it's good enough to just move the |
<!--step0--><!--endstep0-->
What do you think of this commit? |
@sinsukehlab Looks ok. Summary title might be better as We need more opinions at this point and ideally we need some one from the GH Skills team to take a look at this and make a decision on if this is a direction they want to go in. |
I've noted this feedback on an internal issue for the product folks to review. |
The GitHub UI has been changed as a result of the Codespaces feature
I've merged something similar in #28, thank you for the recommendation 🙏🏼 |
Why:
Some learners would like to browse Step 0.
Discussed in https://github.com/orgs/skills/discussions/24
Originally posted by markpatterson27 August 15, 2022
Should the welcome paragraph be included in the step0 scope?
The welcome paragraph includes the course details: 'Who is this for', 'What you'll learn', etc. This paragraph is hidden (along with the 'How to start this course' section) when the course is started (i.e. new repo created from template). I think this paragraph is still useful after the course has started and shouldn't be hidden.
Before opening a series of PRs, I was wondering what other peoples opinions are. Should the welcome paragraph remain visible after course start, or should it be hidden out of the way?
What's being changed:
I changed the style of Step 0.
I put Step 0 in a
<details>
tag instead of commenting it out.Check off the following: