Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step0 Scope - Keep the welcome paragraph visible after course start? #20

Closed
wants to merge 4 commits into from

Conversation

sinsukehlab
Copy link
Contributor

Why:

Some learners would like to browse Step 0.

Discussed in https://github.com/orgs/skills/discussions/24

Originally posted by markpatterson27 August 15, 2022
Should the welcome paragraph be included in the step0 scope?

The welcome paragraph includes the course details: 'Who is this for', 'What you'll learn', etc. This paragraph is hidden (along with the 'How to start this course' section) when the course is started (i.e. new repo created from template). I think this paragraph is still useful after the course has started and shouldn't be hidden.

Before opening a series of PRs, I was wondering what other peoples opinions are. Should the welcome paragraph remain visible after course start, or should it be hidden out of the way?

What's being changed:

I changed the style of Step 0.
I put Step 0 in a <details> tag instead of commenting it out.

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

instead of commenting it out
Details of this course
@markpatterson27
Copy link

I would leave the <!--step0--> <!--endstep0--> comment blocks in. End state would be to still hide the setup instructions after the course is started, but to put the course aims and LO in a details block.

Something like this

<!--<details id=0><summary>Course Aims</summary>-->

TBD-welcome-paragraph

- **Who is this for**: TBD-audience.
- **What you'll learn**: TBD-objective.
- **What you'll build**: TBD-result.
- **Prerequisites**: TBD-prerequisites.
- **How long**: This course is TBD-step-count steps long and takes less than TBD-duration to complete.

<!--</details>-->

<!--step0-->

The skills/action-update-step would also have to be updated to accommodate for blocks being removed from comments instead of added. (i.e. unhide the details tags).

Personally, I think it's good enough to just move the <!--step0--> to below the course aims (i.e. just above ## How to start this course).

@sinsukehlab
Copy link
Contributor Author

sinsukehlab commented Aug 26, 2022

What do you think of this commit?
I don't think skills/action-update-step needs updating for this reason.
I think it needs updating for the CI course though.
Cf. skills/action-update-step#5

@markpatterson27
Copy link

@sinsukehlab Looks ok. Summary title might be better as Course description. My preference is not to put the course aims/description in a <details> tag though (and also take out the summary title).

We need more opinions at this point and ideally we need some one from the GH Skills team to take a look at this and make a decision on if this is a direction they want to go in.

@heiskr
Copy link
Contributor

heiskr commented Aug 26, 2022

I've noted this feedback on an internal issue for the product folks to review.

The GitHub UI has been changed as a result of the Codespaces feature
@heiskr
Copy link
Contributor

heiskr commented Feb 13, 2023

I've merged something similar in #28, thank you for the recommendation 🙏🏼

@heiskr heiskr closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants