-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build(deps-dev): Bump @wordpress/eslint-plugin from 3.4.1 to 4.0.0 #391
Build(deps-dev): Bump @wordpress/eslint-plugin from 3.4.1 to 4.0.0 #391
Conversation
a3c4106
to
3e8b087
Compare
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
========================================
Coverage 0.67% 0.67%
Complexity 90 90
========================================
Files 26 26
Lines 894 894
========================================
Hits 6 6
Misses 888 888 |
ebbefa2
to
f3c5de6
Compare
92d87f0
to
b78a20f
Compare
b78a20f
to
d8a083a
Compare
Bumps [@wordpress/eslint-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin) from 3.4.1 to 4.0.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/@wordpress/[email protected]/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <[email protected]>
d8a083a
to
80fb0c9
Compare
Can you try running |
Hi @gziolo, thanks for the suggestion. I ran The result is that this "fixed" all the issues reported by prettier - it replaced ' with ", removed spaces from parens and changed indentation from tabs to 2 spaces. |
It depends on whether you are fine with the default Prettier configuration. If you want to fully align with WordPress coding styles, you need to add Prettier config as well. You can either copy this file: https://github.com/WordPress/gutenberg/blob/master/packages/scripts/config/.prettierrc.js or wait until WordPress/gutenberg#20026 lands. |
A newer version of @wordpress/eslint-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Superseded by #454. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @wordpress/eslint-plugin from 3.4.1 to 4.0.0.
Release notes
Sourced from @wordpress/eslint-plugin's releases.
Changelog
Sourced from @wordpress/eslint-plugin's changelog.
Commits
7eb5abd
chore(release): publish216e739
Update changelog filesc06a598
Merge changes published in the Gutenberg plugin "release/7.5" branchDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: