Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps-dev): Bump @wordpress/eslint-plugin from 3.4.1 to 4.0.0 #391

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 10, 2020

Bumps @wordpress/eslint-plugin from 3.4.1 to 4.0.0.

Release notes

Sourced from @wordpress/eslint-plugin's releases.

4.0 🍯

Changelog

New Features

  • Add ability to change overlay color in Cover Image.
  • Introduce new Font Size Picker with clear labels and size comparison.
  • Introduce new RichText data structure to allow better manipulation of inline content.
  • Add Pullquote style variation and color palette support.
  • Add support for post locking when multiple authors interact with the editor.
  • Add an alternative block appender when the container doesn’t support the default block (paragraph).
  • Improve the UI and interactions around floats.
  • Add option to skip PublishSidebar on publishing.
  • Add support for shortcode embeds that enqueue scripts.
  • Add a button to exit the Code Editor.
  • Introduce a reusable ResizableBox component.
  • Style nested <ul>s with circles instead of normal bullets.
  • Show hierarchical terms sorted by name and allow them to be filterable through search. Hide the filter box if there are fewer than 8 terms.
  • Improve messaging around invalid block detection.
  • Use text color for links when a paragraph has a color applied.
  • Allow extended usage of the controls API in resolvers within data layer.
  • Ensure that a default block is inserted (and selected) when all other blocks are removed.
  • Enhance the block parser to support multiple type, in accordance with JSON schema.
  • Add a larger target area for resize drag handles.
  • Add media button to classic block.
  • Add control to toggle responsive mechanism on embed blocks.
  • Update sidebar design to have a lighter feeling.
  • Update resolvers in data layer to rely on controls instead of async generators.
  • Set template validity on block reset.
  • Remove dirty detection from Meta Boxes to reduce false positives of “unsaved changes”.
  • Show “Publish: Immediately” for new drafts by inferring floating date.
  • Add a slight transition to Full Screen mode.
  • Improve spacing setup in Gallery Block.
  • Remove additional side padding from blocks.
  • Improve the reusable blocks “Export as JSON” link.
  • Enforce a default block icon size to allow flex alignment and fix unaligned labels.
  • Consider single unmodified default block as empty content.
  • Only display URL input field when “Link To” is set for Image Block.
  • Make backspace behavior consistent among Quote, Verse and Preformatted.
  • Expose refresh method from Dropdown component.
  • Omit style tags when pasting.
  • Use best fitting embed aspect ratio if exact match doesn’t exist.
  • Avoid dispatching undefined results in promise middleware.
  • Change keyboard shortcut for removing a block to access + z.
  • Replace the Full Screen mode “x” icon with a back arrow.
  • Make drag handle visible on hover while in nested contexts.
  • Pass the tab title to the TabPanel component for situations where it may need to be highlighted.
  • Allow setting no alignment when a default alignment exists.
  • Improve title and appender margin fix.
  • Avoid focusing on the close button on modal and try a modal appear animation.
  • Change the URL Input label to match Classic.
... (truncated)
Changelog

Sourced from @wordpress/eslint-plugin's changelog.

4.0.0 (2020-02-10)

Breaking Changes

  • The recommended ruleset checks again code formatting (whitespace, indenting, etc.). These rules are now enforced by Prettier itself through a plugin that diffs the code with its formatted output and reports the differences as lint errors. eslint-plugin-prettier was chosen over options like prettier-eslint because we don't run eslint --fix in hooks as we'd rather leave certain linting errors to be resolved or ignored at the author's discretion. We also don't apply any additional formatting with eslint over prettier, so the overhead would be unnecessary. eslint-plugin-prettier was chosen over options like prettier --check because it's nice to see format errors as you type as it leads you to write code with a more optimal auto-formatted output and it avoids issues like comment directives being moved out of place by prettier and the author not realizing it.
Commits
  • 7eb5abd chore(release): publish
  • 216e739 Update changelog files
  • c06a598 Merge changes published in the Gutenberg plugin "release/7.5" branch
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 10, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch from a3c4106 to 3e8b087 Compare February 10, 2020 21:25
@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #391   +/-   ##
========================================
  Coverage      0.67%   0.67%           
  Complexity       90      90           
========================================
  Files            26      26           
  Lines           894     894           
========================================
  Hits              6       6           
  Misses          888     888

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch 2 times, most recently from ebbefa2 to f3c5de6 Compare February 11, 2020 06:47
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch 2 times, most recently from 92d87f0 to b78a20f Compare February 18, 2020 09:51
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch from b78a20f to d8a083a Compare February 24, 2020 19:35
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch from d8a083a to 80fb0c9 Compare February 24, 2020 19:42
@gziolo
Copy link

gziolo commented Feb 27, 2020

Can you try running npm run lint -- --fix and see if it formats all your code according to the coding style expected by Prettier?

@marekdedic
Copy link
Contributor

Hi @gziolo, thanks for the suggestion.

I ran ./node_modules/eslint/bin/eslint.js src/\*\*/\*.ts --fix as I have the project configured to run the lint with gulp, so your suggested command didn't work. Hope it doesn't mess up anything.

The result is that this "fixed" all the issues reported by prettier - it replaced ' with ", removed spaces from parens and changed indentation from tabs to 2 spaces.

@gziolo
Copy link

gziolo commented Mar 2, 2020

The result is that this "fixed" all the issues reported by prettier - it replaced ' with ", removed spaces from parens and changed indentation from tabs to 2 spaces.

It depends on whether you are fine with the default Prettier configuration. If you want to fully align with WordPress coding styles, you need to add Prettier config as well. You can either copy this file: https://github.com/WordPress/gutenberg/blob/master/packages/scripts/config/.prettierrc.js or wait until WordPress/gutenberg#20026 lands.

@dependabot-preview
Copy link
Contributor Author

A newer version of @wordpress/eslint-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@marekdedic
Copy link
Contributor

Superseded by #454.

@marekdedic marekdedic closed this Apr 17, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@marekdedic marekdedic deleted the dependabot/npm_and_yarn/wordpress/eslint-plugin-4.0.0 branch April 17, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants