Add Prettier shared config package

[ntwb]

Description

Add Prettier shared config package

How has this been tested?

npm run test-unit

npm run test-lint-js

npm run lint-format-js

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[gziolo]

We have configs for other tools so it might make sense to keep one for Prettier. Does it have any custom rule for WordPress setup enforced with the Prettier fork? We could add a note that it can be used with @wordpress/scripts to avoid the hassle and maybe mention the fork as well?

[gziolo]

I think npm run docs:build is necessary to update the manifest for WordPress developers docs. It should make Travis pass.

Can we also update the existing config in @wordpress/scripts to use this new package? In addition, we probably should list it as a dev dependency in the root package.json file (we do it for other configs) and as production dependency in @wordpress/scripts.

[github-actions]

Size Change: 0 B

Total Size: 856 kB

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.01 kB	0 B
build/annotations/index.js	3.43 kB	0 B
build/api-fetch/index.js	3.39 kB	0 B
build/autop/index.js	2.58 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	6.02 kB	0 B
build/block-directory/style-rtl.css	760 B	0 B
build/block-directory/style.css	760 B	0 B
build/block-editor/index.js	100 kB	0 B
build/block-editor/style-rtl.css	10.7 kB	0 B
build/block-editor/style.css	10.7 kB	0 B
build/block-library/editor-rtl.css	7.23 kB	0 B
build/block-library/editor.css	7.24 kB	0 B
build/block-library/index.js	111 kB	0 B
build/block-library/style-rtl.css	7.38 kB	0 B
build/block-library/style.css	7.39 kB	0 B
build/block-library/theme-rtl.css	669 B	0 B
build/block-library/theme.css	671 B	0 B
build/block-serialization-default-parser/index.js	1.65 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	57.7 kB	0 B
build/components/index.js	191 kB	0 B
build/components/style-rtl.css	15.5 kB	0 B
build/components/style.css	15.5 kB	0 B
build/compose/index.js	5.76 kB	0 B
build/core-data/index.js	10.6 kB	0 B
build/data-controls/index.js	1.04 kB	0 B
build/data/index.js	8.21 kB	0 B
build/date/index.js	5.37 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	568 B	0 B
build/dom/index.js	3.06 kB	0 B
build/edit-post/index.js	91.3 kB	0 B
build/edit-post/style-rtl.css	8.64 kB	0 B
build/edit-post/style.css	8.64 kB	0 B
build/edit-site/index.js	4.64 kB	0 B
build/edit-site/style-rtl.css	2.48 kB	0 B
build/edit-site/style.css	2.48 kB	0 B
build/edit-widgets/index.js	4.45 kB	0 B
build/edit-widgets/style-rtl.css	2.58 kB	0 B
build/edit-widgets/style.css	2.58 kB	0 B
build/editor/editor-styles-rtl.css	381 B	0 B
build/editor/editor-styles.css	382 B	0 B
build/editor/index.js	43.8 kB	0 B
build/editor/style-rtl.css	3.97 kB	0 B
build/editor/style.css	3.96 kB	0 B
build/element/index.js	4.45 kB	0 B
build/escape-html/index.js	733 B	0 B
build/format-library/index.js	7.09 kB	0 B
build/format-library/style-rtl.css	502 B	0 B
build/format-library/style.css	502 B	0 B
build/hooks/index.js	1.92 kB	0 B
build/html-entities/index.js	621 B	0 B
build/i18n/index.js	3.49 kB	0 B
build/is-shallow-equal/index.js	710 B	0 B
build/keyboard-shortcuts/index.js	2.3 kB	0 B
build/keycodes/index.js	1.68 kB	0 B
build/list-reusable-blocks/index.js	2.99 kB	0 B
build/list-reusable-blocks/style-rtl.css	226 B	0 B
build/list-reusable-blocks/style.css	226 B	0 B
build/media-utils/index.js	4.85 kB	0 B
build/notices/index.js	1.57 kB	0 B
build/nux/index.js	3.01 kB	0 B
build/nux/style-rtl.css	616 B	0 B
build/nux/style.css	613 B	0 B
build/plugins/index.js	2.54 kB	0 B
build/primitives/index.js	1.49 kB	0 B
build/priority-queue/index.js	779 B	0 B
build/redux-routine/index.js	2.84 kB	0 B
build/rich-text/index.js	14.3 kB	0 B
build/server-side-render/index.js	2.55 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.27 kB	0 B
build/url/index.js	4.01 kB	0 B
build/viewport/index.js	1.61 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.18 kB	0 B

_{compressed-size-action}

[gziolo]

@ntwb – I rebased this branch with master and addressed my own feedback. Feel free to edit my commit if you disagree with any of the changes applied.

This PR should be ready to go.

[ntwb]

Thanks, sorry, have been on holidays and catching up on all the things.

Looks good to me 👍🏼

[ntwb]

Can't approve my own PR 😬

[gziolo]

Thanks, sorry, have been on holidays and catching up on all the things.

I hope you had great time 😃

[aduth]

These values keep being flipped back and forth. I summarized some findings at #16157 (comment) . Out of curiosity, do you use Linux for development (or another OS which would "opt out" of the optional dependencies here)? Or an older version of NPM (older than latest 6.14.2)?

[gziolo]

I'm now on npm 6.14.2, I believe I was on 6.14.1 at the time of this commit. I'm using macOS all the time. I have no idea why this value changes so often.

[aduth]

I strongly suspect it's related to the fact that the dependencies are "optional", though it seems like in macOS they would not typically be skipped. In any case, it does feel like it's something largely on npm's end (i.e. I do not think it's correct that this would ever be false). Wondering if we could do something to address it in the meantime though. For example, we could create a script which is run during the build and verifies deeply that there are no "resolved": false in package-lock.json. But I'm not sure yet how we make these issues actionable from the perspective of the pull request author; in other words, how it would be expected that you would fix the problem.