Next fakes #1700
Merged
Next fakes #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clearer what the tip about using `sinon.reset()` for resetting stubs actually does.
Explain how to update to use the default sandbox
11 tasks
|
Thanks |
glasserc
added a commit
to Kinto/kinto-http.js
that referenced
this pull request
Apr 9, 2018
* Update tests to include bucket:create permission * Use sinon.createSandbox instead of sinon.sandbox.create This seems to be the first of many consequences from sinonjs/sinon#1586 and sinonjs/sinon#1700. I'm not sure what the final result of all of this will be -- we might not even need this sandbox any more, because a default one is created for us -- but at some point in the future, we'll probably have to rewrite everything that uses a stub(), and I prefer to wait until then to make any drastic changes. This just silences the warnings until then. * Try to make tests work on both kinto versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1586.
It is a solution for the proposal in #1559, and will be merged into the
nextbranch.The only difference between the two is that I used
git rebase -ia lot and tidied up the history, so it will read better for Future ContributorTasks
sinonobject a defaultsandboxsandbox.replacemethodsandbox.replacesandbox.replaceGettermethodsandbox.replaceGettersandbox.replaceSettermethodsandbox.replaceSettersinon.fakefake[.withArguments, etc]sinon.fakesinon@nextto get feedback