🏗 Upgrade sinon
to 6.1.4 and forbid importing of sinon
#17197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up where #14779 left off, and does the following:
sinon
to version 6, which fixes issues like Default sandbox: useFakeXMLHttpRequest is not restored correctly sinonjs/sinon#1840 and otherssinon.sandbox.create()
calls with the globalsinon.sandbox
(see New API: default sandbox and fake sinonjs/sinon#1586 and Next fakes sinonjs/sinon#1700)beforeEach()
in caseafterEach()
wasn't run (Fix usage ofthis.skip()
within tests #17245)spy.reset()
calls tospy.resetHistory()
(see Deprecate spy.reset() in favor of the more explicit spy.resetHistory() sinonjs/sinon#1446)*
fromsinon
, as we used to do earlier (copied from 🏗Forbid importing sinon #14779)Fixes #17190
Partial fix for #14360
Closes #16372
Closes #14779