Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Upgrade sinon to 6.1.4 and forbid importing of sinon #17197

Merged
merged 1 commit into from
Aug 2, 2018
Merged

🏗 Upgrade sinon to 6.1.4 and forbid importing of sinon #17197

merged 1 commit into from
Aug 2, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 30, 2018

This PR picks up where #14779 left off, and does the following:

Fixes #17190
Partial fix for #14360
Closes #16372
Closes #14779

@rsimha rsimha self-assigned this Jul 30, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Jul 30, 2018

/to @prateekbh @jridgewell

@codecov-io
Copy link

Codecov Report

Merging #17197 into master will increase coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #17197     +/-   ##
=========================================
+ Coverage   76.82%   77.73%   +0.9%     
=========================================
  Files         561      562      +1     
  Lines       41140    41197     +57     
=========================================
+ Hits        31606    32024    +418     
+ Misses       9534     9173    -361
Flag Coverage Δ
#integration_tests 36.13% <ø> (?)
#unit_tests 76.78% <ø> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8056da5...88c9e33. Read the comment docs.

@rsimha rsimha merged commit c7e5fc3 into ampproject:master Aug 2, 2018
@rsimha rsimha deleted the 2018-07-30-Sinon branch August 2, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sinon to > 6.1.1
4 participants