Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'bridge' parameter down into relevant function when calling 'up' #69

Merged
merged 3 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
The versions coincide with releases on pypi.

## [0.1.x](https://github.com/singularityhub/singularity-compose/tree/master) (0.1.x)
- fix 'bridge' option for 'up' command (0.1.18)
- add support for instance replicas (0.1.17)
- fix check command validation (0.1.16)
- fix a bug triggered when using startoptions in conjunction with network=false (0.1.15)
Expand Down
1 change: 1 addition & 0 deletions scompose/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@
with this file, You can obtain one at http://mozilla.org/MPL/2.0/.

"""

from .version import __version__
4 changes: 1 addition & 3 deletions scompose/project/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ def down(self, names=None, timeout=None):
def create(
self, names=None, writable_tmpfs=True, bridge="10.22.0.0/16", no_resolv=False
):

"""
Call the create function, which defaults to the command instance.create()
"""
Expand All @@ -466,7 +465,6 @@ def up(
bridge="10.22.0.0/16",
no_resolv=False,
):

"""
Call the up function, instance.up().

Expand All @@ -476,6 +474,7 @@ def up(
names,
command="up",
writable_tmpfs=writable_tmpfs,
bridge=bridge,
no_resolv=no_resolv,
)

Expand All @@ -487,7 +486,6 @@ def _create(
bridge="10.22.0.0/16",
no_resolv=False,
):

"""
Create one or more instances.

Expand Down
2 changes: 1 addition & 1 deletion scompose/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

"""

__version__ = "0.1.17"
__version__ = "0.1.18"
AUTHOR = "Vanessa Sochat"
AUTHOR_EMAIL = "[email protected]"
NAME = "singularity-compose"
Expand Down
Loading