Pass 'bridge' parameter down into relevant function when calling 'up' #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Could you please bump version.py and add an entire to CHANGELOG.md? |
|
And let me know if you'd like me to do the changes and push here for you. |
Sure thing, done |
vsoch
approved these changes
Mar 28, 2024
|
You just need black 24.3.0 |
|
CI doesn't appear to be running for the latest change? |
|
I have to approve it since you are a new contributor, and I fell back asleep - apologies! |
|
And I realize our circle (main CI) hasn't been running for a while - it's out of scope for the PR here but I'll work on it and try to restore it working in GHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'bridge' parameter wasn't passed along, so
upfailed in environments where the singularity bridge wasn't the default10.22.0.0/16.Just had to passed down into the
_createfunction.