Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Add ASAN run of CI to weekly CI job #3434

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Dec 13, 2024

  1. Update bld/script.sh to skip downloading TileDB prebuilt for all non-Release configurations.
  2. Add new weekly CI job that runs the CI for the ASAN configuration.
  3. Update developer docs for building with sanitizers.

[sc-34306]

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (8d92cb5) to head (89268d2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
+ Coverage   86.22%   86.29%   +0.06%     
==========================================
  Files          55       55              
  Lines        6295     6305      +10     
==========================================
+ Hits         5428     5441      +13     
+ Misses        867      864       -3     
Flag Coverage Δ
python 86.29% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.29% <ø> (+0.06%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member

@jp-dark is there a way to manually trigger a run of this PR before merging it? (From https://github.com/single-cell-data/TileDB-SOMA/actions I think not ...)

@jp-dark jp-dark force-pushed the dark/asan-ci/sc-34306 branch from b6a356b to dd21340 Compare December 13, 2024 22:29
@jp-dark jp-dark force-pushed the dark/asan-ci/sc-34306 branch from dd21340 to 1825a77 Compare December 13, 2024 22:29
@jp-dark
Copy link
Collaborator Author

jp-dark commented Dec 13, 2024

@jp-dark is there a way to manually trigger a run of this PR before merging it? (From https://github.com/single-cell-data/TileDB-SOMA/actions I think not ...)

I updated it to run in the PR if it is modified. However, it is almost certainly going to fail.

@jp-dark jp-dark force-pushed the dark/asan-ci/sc-34306 branch 3 times, most recently from d779344 to 28e0b3b Compare December 16, 2024 17:35
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jp-dark jp-dark force-pushed the dark/asan-ci/sc-34306 branch from 28e0b3b to 17c5a8a Compare December 16, 2024 17:45
@jp-dark jp-dark force-pushed the dark/asan-ci/sc-34306 branch from 17c5a8a to 89268d2 Compare December 16, 2024 18:56
@jp-dark jp-dark merged commit 68eeced into main Dec 16, 2024
15 of 16 checks passed
@jp-dark jp-dark deleted the dark/asan-ci/sc-34306 branch December 16, 2024 19:09
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
* Update Makefile and dev docs for sanitizer builds
* Add weekly workflow for ASAN CI
* Run workflow for PRs that modify workflow
johnkerl pushed a commit that referenced this pull request Dec 17, 2024
* Update Makefile and dev docs for sanitizer builds
* Add weekly workflow for ASAN CI
* Run workflow for PRs that modify workflow

Co-authored-by: Julia Dark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants