-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Remove double open For SOMAArray
reads
#3293
[python] Remove double open For SOMAArray
reads
#3293
Conversation
SOMAArray
ReadsSOMAArray
reads
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
==========================================
+ Coverage 85.83% 86.03% +0.20%
==========================================
Files 55 55
Lines 6191 6174 -17
==========================================
- Hits 5314 5312 -2
+ Misses 877 862 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really really nice --a well-thought-out refactor, well executed. Just some minor mods requested. :)
89cd943
to
47c6f9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Two small items:
- platform_config handling - noted inline
- ManagedQuery GIL - the read path moves some logic up from C++ to Python -- we need to make sure the pybind entry points are all releasing GIL where appropriate. My quick skim is that it looks OK, but I suggest we benchmark after landing this to confirm.
ac764f8
to
9124aff
Compare
37a03f2
to
dc61711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of cleanup needed in _read_iters.py - comments inline
eb6239c
to
226f768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor pythonic / lint items, but otherwise LGTM.
Co-authored-by: John Kerl <[email protected]>
Co-authored-by: John Kerl <[email protected]>
* This passes locally but have had issues on CI in past attempts
778def5
to
4b7f6bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Thank you @nguyenv !!!
Issue and/or context: #3472
This finishes up #3053 [sc-54744]
Changes:
clib.SOMAArray.open
in allSOMAArray
derived classread
callsclib.SOMAArray.open
orclib.SOMAArray.reset
instead toTableReadIter
andSparseNDArrayRead
_set_coords
on theManagedQuery
rather than throughSOMAArray
_arrow_table_reader
andSparseTensorReadIterBase
initialize aManagedQuery
object and set the query arguments listed above; set up the read; and submit reads and return results until the query is complete[sc-59595]