Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python/c++] Release GIL in IntIndexer C++ code #3345

Closed
johnkerl opened this issue Nov 19, 2024 · 2 comments
Closed

[python/c++] Release GIL in IntIndexer C++ code #3345

johnkerl opened this issue Nov 19, 2024 · 2 comments
Assignees
@bkmartinjr
Labels
for-release-1.15 python-api

Comments

@johnkerl
Copy link
Member

johnkerl commented Nov 19, 2024 •
edited
Loading

The Python IntIndexer bindings fail to release the GIL. These are long-running entry points and should release it.

@bkmartinjr has benchmarked on some threaded code, and has found that this change improves concurrency.

[sc-59595]

See also #3345.
@johnkerl johnkerl mentioned this issue Nov 19, 2024
Merged
@johnkerl johnkerl changed the title [python] Release GIL in IntIndexer C++ code [python] Outgest-related performance improvements Nov 19, 2024
This was referenced Nov 19, 2024
Merged
Merged
Merged
Merged
@johnkerl
Copy link
Member Author

@bkmartinjr can we close this one, given other open issues such as #3293 and #3353?

@johnkerl johnkerl changed the title [python] Outgest-related performance improvements [python] Some outgest-related performance improvements Nov 26, 2024
@bkmartinjr
Copy link
Member

@johnkerl - fixed by #3344

@johnkerl johnkerl changed the title [python] Some outgest-related performance improvements [python/C++] Release GIL in IntIndexer C++ code Nov 26, 2024
@johnkerl johnkerl changed the title [python/C++] Release GIL in IntIndexer C++ code [python/c++] Release GIL in IntIndexer C++ code Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkmartinjr bkmartinjr

Labels
for-release-1.15 python-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnkerl @bkmartinjr