[r] Handle numeric coords better in SOMASparseNDArray$read()
#3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in handling of numeric coordinates when reading a sparse array. Now, always cast any integerish value to `bit64::integer64` (casting a `bit64::integer64` to a `bit64::integer64` is a no-op). Also strengthen value checking of `coords` to - require `coords` to be a list of `NULL` or positive, finite, integerish values - require `coords` to have a length - require `coords` to be a list of length `array$dimnames()` or be named with `array$dimnames()` - filter `NULLs` from `coords`; if `coords` is all `NULL`, convert to `NULL` Modified SOMA methods: - `SOMANDArrayBase$private$.convert_coords()`: cast all integerish values to `bit64::integer64`; strengthen value checking of `coords` [SC-57096](https://app.shortcut.com/tiledb-inc/story/57096)
Bump develop version [ci skip]
mojaveazure
deleted the
paulhoffman/sc-57096/tiledbsoma-r-somasparsendarray-read-does
branch
johnkerl
added a commit
that referenced
this pull request
Oct 8, 2024
johnkerl
added a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in handling of numeric coordinates when reading a sparse array. Now, always cast any integerish value to
bit64::integer64(casting abit64::integer64to abit64::integer64is a no-op). Also strengthen value checking ofcoordstocoordsto be a list ofNULLor positive, finite, integerish valuescoordsto have a lengthcoordsto be a list of lengtharray$dimnames()or be named witharray$dimnames()NULLsfromcoords; ifcoordsis allNULL, convert toNULLModified SOMA methods:
SOMANDArrayBase$private$.convert_coords(): cast all integerish values tobit64::integer64; strengthen value checking ofcoordsSC-57096