Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use somacore 1.0.16 #3035

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[python] Use somacore 1.0.16 #3035

merged 4 commits into from
Sep 25, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl
Copy link
Member Author

johnkerl commented Sep 23, 2024

Weird that CI isn't finding somacore 1.0.16 b/c https://pypi.org/project/somacore/1.0.16/#files definitely exists (> 30 minutes now) ...

And I ran pip install somacore==1.0.16 successfully on my laptop just now ... 🤔

@johnkerl
Copy link
Member Author

Derp, PEBKAC :) -- needs #3021

@johnkerl johnkerl changed the base branch from main to rw/py38 September 23, 2024 21:47
@johnkerl johnkerl changed the base branch from rw/py38 to main September 23, 2024 21:47
@johnkerl johnkerl force-pushed the kerl/use-somacore-1.0.16 branch from 1ed3ebb to d09a911 Compare September 23, 2024 21:48
@johnkerl johnkerl changed the base branch from main to rw/py38 September 23, 2024 21:50
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (d1f401d) to head (d09a911).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
+ Coverage   89.64%   89.94%   +0.29%     
==========================================
  Files          40       41       +1     
  Lines        4096     4107      +11     
==========================================
+ Hits         3672     3694      +22     
+ Misses        424      413      -11     
Flag Coverage Δ
python 89.94% <57.14%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.94% <57.14%> (+0.29%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Base automatically changed from rw/py38 to main September 25, 2024 13:24
@johnkerl johnkerl merged commit d31ff0c into main Sep 25, 2024
32 checks passed
@johnkerl johnkerl deleted the kerl/use-somacore-1.0.16 branch September 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants