Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Drop support for Python 3.8 #3021

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[python] Drop support for Python 3.8 #3021

merged 3 commits into from
Sep 25, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Sep 20, 2024

Issue and/or context: this is a rebase of #2949, for debugging CI failures (harder for me to trigger/debug them on branch kounelisagis:agis/drop-py38-support)

#2141
sc-41048

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (d1f401d) to head (8847690).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   89.64%   89.94%   +0.29%     
==========================================
  Files          40       41       +1     
  Lines        4096     4107      +11     
==========================================
+ Hits         3672     3694      +22     
+ Misses        424      413      -11     
Flag Coverage Δ
python 89.94% <57.14%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.94% <57.14%> (+0.29%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams changed the title [python] Drop support for Python 3.8 (alternate PR) [python] Drop support for Python 3.8 Sep 23, 2024
@ryan-williams ryan-williams marked this pull request as ready for review September 23, 2024 13:32
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
Co-authored-by: John Kerl <[email protected]>
@ryan-williams ryan-williams merged commit a724018 into main Sep 25, 2024
22 checks passed
@ryan-williams ryan-williams deleted the rw/py38 branch September 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants