[c++] Implementation and unit testing for domainish accessors #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/polydom4
branch
3 times, most recently
from
411f03f to
2af8d05
Compare
johnkerl
force-pushed
the
kerl/polydom3
branch
from
bb4a436 to
fba692e
Compare
johnkerl
force-pushed
the
kerl/polydom4
branch
from
2af8d05 to
dfed646
Compare
johnkerl
force-pushed
the
kerl/polydom4
branch
5 times, most recently
from
6f3f34e to
d673224
Compare
johnkerl
force-pushed
the
kerl/polydom4
branch
from
d673224 to
e2b6621
Compare
johnkerl
force-pushed
the
kerl/polydom4
branch
4 times, most recently
from
bc63b1e to
6de0c4b
Compare
johnkerl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 89.64% 89.79% +0.14%
==========================================
Files 40 40
Lines 4096 4096
==========================================
+ Hits 3672 3678 +6
+ Misses 424 418 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/polydom4
branch
from
6de0c4b to
d488087
Compare
nguyenv
reviewed
Sep 20, 2024
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
nguyenv
approved these changes
Sep 20, 2024
Co-authored-by: nguyenv <[email protected]>
johnkerl
force-pushed
the
kerl/polydom4
branch
from
7dd8412 to
cc0b03f
Compare
johnkerl
added a commit
that referenced
this pull request
Sep 20, 2024
johnkerl
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
This is atop #3011; these will replace #2995.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Notes for Reviewer:
Python/R PRs will be separate.