Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Pre-neatens for polymorphic domainish accessors #3011

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 17, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

This is split out from #2995 to make 2995 simpler.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

These are higher-line-count mods, which would distract from the more substantive mods on 2995.

Changes:

Notes for Reviewer:

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (29be284) to head (fba692e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          40       40              
  Lines        4096     4096              
==========================================
+ Hits         3672     3678       +6     
+ Misses        424      418       -6     
Flag Coverage Δ
python 89.79% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 6f723d4 into main Sep 18, 2024
25 checks passed
@johnkerl johnkerl deleted the kerl/polydom3 branch September 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants