Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Pre-neatens before making unit-test helpers for variant-indexed dataframes #2936

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 28, 2024

Issue and/or context: This is a line-count-reducing under-diff following on #2919 for issue #2407 / [sc-51048].

The intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Just some prep for my next step to unit-test #2916 and #2917, namely, we need libtiledbsoma-level support for variant-indexed dataframes (those whose dim is something other than a single int64).

Notes for Reviewer:

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (ae3e417) to head (1738f7e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   89.87%   90.02%   +0.15%     
==========================================
  Files          38       38              
  Lines        3999     3999              
==========================================
+ Hits         3594     3600       +6     
+ Misses        405      399       -6     
Flag Coverage Δ
python 90.02% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.02% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl requested a review from jp-dark August 28, 2024 18:33
Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor comment but everything lgtm

libtiledbsoma/test/common.cc Outdated Show resolved Hide resolved
@johnkerl johnkerl merged commit 431e0ce into main Aug 28, 2024
@johnkerl johnkerl deleted the kerl/cpp-ut-helper-neaten branch August 28, 2024 19:10
@johnkerl
Copy link
Member Author

Thanks @nguyenv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants