-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] verify_core_versions()
during import tiledbsoma
#2437
Conversation
I like the 'hatch' -- thumps up. I considered adding such an override in the R package's |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
- Coverage 90.61% 90.43% -0.19%
==========================================
Files 37 37
Lines 3900 3940 +40
==========================================
+ Hits 3534 3563 +29
- Misses 366 377 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -156,7 +156,7 @@ | |||
get_SOMA_version, | |||
get_storage_engine, | |||
show_package_versions, | |||
verify_core_versions, | |||
_verify_core_versions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't clear -- let's keep this tiledbsoma._general_utilities.verify_core_versions
but just don't auto-export it in the package-level __init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryan-williams so sorry!! I misread this as you populating __all__
-- but you very much are not
Let's just call it verify_core_versions
and this will be fine
e51b71a
to
fbe7a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sorry again about the misdirect! 😓
* verify_core_versions() during `import tiledbsoma` * add comment
…2443) * verify_core_versions() during `import tiledbsoma` * add comment Co-authored-by: Ryan Williams <[email protected]>
Issue and/or context: #1837
Changes:
verify_core_versions
helper which asserts that TileDB-Py's andlibtiledbsoma
's core versions matchverify_core_versions()
totiledbsoma.__init__.py
TILEDB_CORE_MISMATCHED_VERSIONS_ERROR_LEVEL=err
"escape hatch"; if the check above catches any users, and they really want to just keep running and fix it later, this allows it (but prints a relevant error message).show_package_versions
output:Notes for Reviewer:
pytiledbsoma.version
, which callstiledbsoma::version::as_string()
, which callstiledb_version
.libtiledbsoma
, notlibtiledb
.