Skip to content

Commit

Permalink
cr feedback, add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ryan-williams committed Apr 12, 2024
1 parent 2b2f215 commit e51b71a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 5 additions & 2 deletions apis/python/src/tiledbsoma/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
get_SOMA_version,
get_storage_engine,
show_package_versions,
verify_core_versions,
_verify_core_versions,
)
from ._indexer import IntIndexer, tiledbsoma_build_index
from ._measurement import Measurement
Expand All @@ -169,7 +169,10 @@
tiledbsoma_stats_reset,
)

verify_core_versions()
# Ensure TileDB-Py and libtiledbsoma have matching core versions; if they don't, undefined behavior
# / segfaults may ensue. Once libtiledbsoma is the only "path to core" (cf. #1632), this can be
# removed.
_verify_core_versions()

__version__ = get_implementation_version()

Expand Down
4 changes: 2 additions & 2 deletions apis/python/src/tiledbsoma/_general_utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def get_libtiledbsoma_core_version() -> str:
)


def verify_core_versions() -> None:
def _verify_core_versions() -> None:
"""Verify that the versions of libtiledb used by the `tiledb` Python library and
libtiledbsoma are the same.
Expand Down Expand Up @@ -131,4 +131,4 @@ def show_package_versions() -> None:
print("python version ", ".".join(str(v) for v in sys.version_info))
print("OS version ", u.system, u.release)
# fmt: on
verify_core_versions()
_verify_core_versions()

0 comments on commit e51b71a

Please sign in to comment.