[python] Check for downgraded categorical write #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/categ-downgrade-check
branch
3 times, most recently
from
e079c1f to
6a9b398
Compare
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 75 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
johnkerl
changed the title
nguyenv
reviewed
Oct 2, 2023
|
@nguyenv ready for round two! |
bkmartinjr
reviewed
Oct 2, 2023
bkmartinjr
reviewed
Oct 2, 2023
bkmartinjr
previously requested changes
Oct 2, 2023
Co-authored-by: Vivian Nguyen <[email protected]>
johnkerl
force-pushed
the
kerl/categ-downgrade-check
branch
from
097e439 to
86d6c10
Compare
nguyenv
approved these changes
Oct 2, 2023
bkmartinjr
approved these changes
Oct 3, 2023
johnkerl
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* [python] Check for downgraded categorical write * lint * bugfix on append-is-rewrite corner case * CI from 1749 * fix broken test * unit-test case * docstrings * code-review feedback Co-authored-by: Vivian Nguyen <[email protected]> * fix broken indentation in review suggestion * code-review feedback --------- Co-authored-by: Vivian Nguyen <[email protected]>
johnkerl
added a commit
that referenced
this pull request
Oct 3, 2023
* [python] Check for downgraded categorical write * lint * bugfix on append-is-rewrite corner case * CI from 1749 * fix broken test * unit-test case * docstrings * code-review feedback * fix broken indentation in review suggestion * code-review feedback --------- Co-authored-by: John Kerl <[email protected]> Co-authored-by: Vivian Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #1739
Changes:
Notes for Reviewer: