Skip to content

Commit

Permalink
code-review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
johnkerl committed Oct 2, 2023
1 parent 453b922 commit 097e439
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion apis/python/src/tiledbsoma/_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,8 @@ def write(
If a column is of categorical type in the schema and a flattened/non-categorical
column is presented for data on write, a ``ValueError`` is raised. If a column is
of non-categorical type in the schema and a categorical column is presented for data
on write, the data are auto-flattened on behalf of the user.
on write, the data are written as an array of category values, and the category-type
information is not saved.
Raises:
TypeError:
Expand Down
3 changes: 1 addition & 2 deletions apis/python/tests/test_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ def test_dataframe_with_float_dim(tmp_path, arrow_schema):
assert sdf.index_column_names == ("bar",)


@pytest.mark.parametrize("downgrade", [False, True])
def test_dataframe_with_enumeration(tmp_path, downgrade):
def test_dataframe_with_enumeration(tmp_path):
schema = pa.schema(
[
pa.field("foo", pa.dictionary(pa.int64(), pa.large_string())),
Expand Down

0 comments on commit 097e439

Please sign in to comment.