[ci] MacOS CI updates #1695
Merged
[ci] MacOS CI updates #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
Sep 18, 2023
johnkerl
added a commit
that referenced
this pull request
Sep 18, 2023
Co-authored-by: John Kerl <[email protected]>
johnkerl
pushed a commit
that referenced
this pull request
Sep 20, 2023
johnkerl
pushed a commit
that referenced
this pull request
Sep 20, 2023
* logger->set_pattern call should be unconditional, not windows-only * Remove EXCLUDE_FROM_ALL annotation on unit_soma, so that the target updates reliably * Add note about failure mode on a fork Co-authored-by: Isaiah Norton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neaten of #1692. Findings by @ihnorton. Parent context #866.