Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] CI canary [WIP/RFC] #1692

Closed
wants to merge 9 commits into from
Closed

[ci] CI canary [WIP/RFC] #1692

wants to merge 9 commits into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 17, 2023

Internal-only/debug-only canary to examine CI issues arising simultaneously with #1691, while apparently not caused by #1691.

Our post-merge CI has fail-fast set to false -- run all tests to completion -- while our pre-merge CI has fail-fast set to true. This is, generally, a good idea as a large chunk of our CI compute resources are absorbed by pre-merge CI. However, on #1691 I want to see if the Python 3.7 fail there is related only to 3.7. As is on #1691, with fail-fast set to true, the 3.7 fail is cancelling signal from the other CI jobs.

Parent context: #866.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

📢 Thoughts on this report? Let us know!.

@johnkerl
Copy link
Member Author

johnkerl commented Sep 17, 2023

This is progress: 9a08fcc

Before: a CI error involving

ImportError: dlopen(/Users/runner/work/TileDB-SOMA/TileDB-SOMA/apis/python/src/tiledbsoma/pytiledbsoma.cpython-310-darwin.so, 0x0002): symbol not found in flat namespace (__ZN10tiledbsoma8LOG_INFOERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE)

where the symbol demangles to

_tiledbsoma::LOG_INFO(
    std::__cxx11::basic_string<
        char,
        std::char_traits<char>,
        std::allocator<char>
    > const&
)

-- note the placement of the const keyword after the string bit, and right before the &. We do have another error; but I believe this has fixed one of the two issues.

cc @ihnorton @Shelnutt2

@johnkerl johnkerl marked this pull request as ready for review September 17, 2023 21:34
@johnkerl johnkerl changed the title [ci] CI canary [WIP] [ci] CI canary [WIP/RFC] Sep 17, 2023
@johnkerl
Copy link
Member Author

Superseded by #1695

@johnkerl johnkerl closed this Sep 18, 2023
@johnkerl johnkerl deleted the kerl/fail-not-fast branch October 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants